Make ripunzip installer accessible from outside this repo. #17291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The relative path to misc doesn't work when running from another repo * The buildifier dependency is not available from other repos, therefore we can't pull in //misc/bazel without further refactoring. Therefore, inline the runfiles snippet here.
redsun82
reviewed
Aug 23, 2024
misc/ripunzip/install.sh
Outdated
Comment on lines
5
to
14
| # --- begin runfiles.bash initialization v3 --- | ||
| # Copy-pasted from the Bazel Bash runfiles library v3. | ||
| set -uo pipefail; set +e; f=bazel_tools/tools/bash/runfiles/runfiles.bash | ||
| source "${RUNFILES_DIR:-/dev/null}/$f" 2>/dev/null || \ | ||
| source "$(grep -sm1 "^$f " "${RUNFILES_MANIFEST_FILE:-/dev/null}" | cut -f2- -d' ')" 2>/dev/null || \ | ||
| source "$0.runfiles/$f" 2>/dev/null || \ | ||
| source "$(grep -sm1 "^$f " "$0.runfiles_manifest" | cut -f2- -d' ')" 2>/dev/null || \ | ||
| source "$(grep -sm1 "^$f " "$0.exe.runfiles_manifest" | cut -f2- -d' ')" 2>/dev/null || \ | ||
| { echo>&2 "ERROR: cannot find $f"; exit 1; }; f=; set -e | ||
| # --- end runfiles.bash initialization v3 --- |
There was a problem hiding this comment.
bleurgh, I wanted to avoid this... couldn't we just list our two possibilities?
source misc/bazel/runfiles.sh || source ql~/misc/bazel/runfiles.sh # or whateverThere was a problem hiding this comment.
ah, there's the buildfier thing. I would just remove the dev_dependency=True to that. In any case codeql is not meant to be used as a dependency for anything else than semmle-code. Also, the correct suggestion here is
source misc/bazel/runfiles.sh 2>/dev/null || source external/ql~/misc/bazel/runfiles.shThere was a problem hiding this comment.
but I'd be ok if you insist 🙂
There was a problem hiding this comment.
As you delivered the correct path, I'll fix the buildifier thing :D
It is another dependency on tilde versus plus we'll have to fix, but oh well.
redsun82
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Therefore, inline the runfiles snippet here.