Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel/Go: Bump rules_go to 0.50.0 #17359

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

mbg
Copy link
Member

@mbg mbg commented Sep 3, 2024

As noted by @criemen in #17058, rules_go version 0.50.0 is out which contains a bug fix for Windows that is needed for Go 1.23. I have teased this out into its own PR since it should be fine to merge independently of the Go 1.23 work and we can then remove the code owners hit on codeql-ci-reviewers for those PRs.

@mbg mbg self-assigned this Sep 3, 2024
@mbg mbg requested a review from a team as a code owner September 3, 2024 11:44
Copy link
Collaborator

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes, thanks!

We'll probably still hit codeowners with the bump of the go toolchain version, though.

@mbg
Copy link
Member Author

mbg commented Sep 3, 2024

Ah yes, good point! Well, it's the thought that counts 😅

@mbg mbg merged commit 5e390a3 into main Sep 3, 2024
19 checks passed
@mbg mbg deleted the mbg/bazel/dependencies/rules_go-0.50.0 branch September 3, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants