Rust: merge current status of experimental extractor into main #17435
Conversation
This should make the rust-analyzer library look for a rust toolchain and try to start the proc-macro server.
This generates test source files from code blocks in class docstrings.
By default the test code is generated as is, but it can optionally:
* be wrapped in a function providing an adequate context using
`@rust.doc_test_function(name, *, lifetimes=(), return_type="()", **kwargs)`,
with `kwargs` providing both generic and normal params depending on
capitalization
* be skipped altogether using `@rust.skip_doc_test`
So for example an annotation like
```python
@rust.doc_test_function("foo",
lifetimes=("a",),
T="Eq",
x="&'a T",
y="&'a T",
return_type="&'a T")
```
will result in the following wrapper:
```rust
fn foo<'a, T: Eq>(x: &'a T, y: &'a T) -> &'a T {
// example code here
}
```
Bazel: remove non-working fake `tree-sitter-extractor` workaround
Rust: Add a README.md
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final override predicate shouldBePrinted() { shouldPrint(ast) } | ||
|
|
||
| override predicate hasChild(PrintAstNode child, int index, string label) { | ||
| child = TPrintLocatable(any(Locatable c | c = getChildAndAccessor(ast, index, label))) |
Check warning
Code scanning / CodeQL
Expression can be replaced with a cast Warning
redsun82
force-pushed
the
rust-experiment
branch
from
58f6310
to
d8db0e4
Compare
Rust: Basic control flow graph setup
| * that starts a basic block to `cfn` along the `intraBBSucc` relation. | ||
| */ | ||
| cached | ||
| predicate bbIndex(CfgNode bbStart, CfgNode cfn, int i) = |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
|
|
||
| private import rust | ||
| private import internal.ControlFlowGraphImpl | ||
| private import internal.Completion |
Check warning
Code scanning / CodeQL
Redundant import Warning
| - id: end-of-file-fixer | ||
| exclude: /test/.*$(?<!\.ql)(?<!\.qll)(?<!\.qlref)|.*\.patch | ||
| exclude: /test/.*$(?<!\.qlref)|.*\.patch$|.*\.qll?$ |
There was a problem hiding this comment.
Was .ql deleted from this on purpose?
There was a problem hiding this comment.
before, ql files were included, now they are excluded always (it's in the qll? pattern): I found a corner case where this check was not agreeing with our ql formatter, who was inserting two newlines at the end. So we can leave our formatter deal with ql and qll files, and no other linter to interfere with that.
| @@ -4,6 +4,5 @@ | |||
| --ql-output=ql/lib/codeql/swift/generated | |||
| --ql-stub-output=ql/lib/codeql/swift/elements | |||
| --ql-test-output=ql/test/extractor-tests/generated | |||
| --generated-registry=ql/.generated.list | |||
There was a problem hiding this comment.
there is now a default deduced from the other outputs (i.e. the longest common path, which amounts to the same location)
I'll call it out, good point. It was confirmed by DCA, but it's still good to have eyes on those changes. |
This will require an internal PR for integration of the rust extractor in the internal build system, but should be independent of that for CI purposes.
For ruby, the changes involve getting rid of the fake create workaround as described with more context here. This involved creating a cargo workspace at the root of
codeqlincluding the shared tree-sitter extractor and the two extractors using them (that we build with bazel, I'm ignoringqlhere).This had the side effect of moving the cargo output directory up in the repository root, which is what causes the other changes around
ruby.