-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust: make the cli flags override automatic #17441
Conversation
This makes the clap flags overlay over `Config` entirely derived via an attribute macro. Also, the `--intputs-file` option is replaced by a more standard and versatile `@` parameter file mechanism.
This looks great. Have you checked that the |
Yes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Any idea why Python tests would be failing for this pull request?
Discussing it on slack, but in the meantime a rerun worked 🤷 |
This makes the clap flags overlay over
Config
entirely derived via an attribute macro. Also, the--intputs-file
option is replaced by a more standard and versatile@
parameter file mechanism.