Java/Kotlin: Deprecate Field.getSourceDeclaration(), Field.isSourceDeclaration() #17503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
igfoo
force-pushed
the
igfoo/fields
branch
7 times, most recently
from
2bb3071
to
c295614
Compare
igfoo
changed the title
It was always the same as the id column.
…ation() Also follows the removal of the sourceid column of fields.
…and Field.isSourceDeclaration()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has always(?) just returned the original field, as we don't extract fields for instantiations of generic types.
Also removes
fields.sourceid, which is always the same asfields.id.