Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen: allow to attach docstrings after the definition #17516

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

redsun82
Copy link
Contributor

No description provided.

@redsun82 redsun82 requested a review from a team as a code owner September 19, 2024 10:44
def annotate(annotated_cls: type) -> _Callable[[type], None]:
"""
Add or modify schema annotations after a class has been defined
For the moment, only docstring annotation is supported. In the future, any kind of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to also support the QL test function signature annotation.

Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and so simple!

@aibaars aibaars merged commit f38f818 into main Sep 19, 2024
18 checks passed
@aibaars aibaars deleted the redsun82/codegen-annotate branch September 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants