Java: Improve weak crypto query #17869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcogs33
force-pushed
the
jcogs33/improve-weak-crypto
branch
from
8fbd6bf
to
459d168
Compare
|
DCA alert changes look reasonable. |
jcogs33
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes weak hash algorithms such as MD5 and SHA1 from
java/weak-cryptographic-algorithmand adds these cases tojava/potentially-weak-cryptographic-algorithminstead.The removal of weak hash algorithms from
java/weak-cryptographic-algorithmaligns with other languages, e.g. #11129.Consideration
Let me know if there is any concern with changing the behavior of
rankedInsecureAlgorithminstead of doing the exclusion forjava/weak-cryptographic-algorithmdirectly in BrokenAlgoLiteral? I chose to do the exclusion inrankedInsecureAlgorithmsince doing so automatically adds the weak hash cases tojava/potentially-weak-cryptographic-algorithmdue to this code.Note that there were some overlapping results between the two queries for cases where a weak hash algorithm string literal is used as the default value in a
getPropertycall (e.g. the "MD5" value in this test case). In order to avoid duplicate results for these cases in thejava/potentially-weak-cryptographic-algorithmquery, I've added an exclusion toInsecureAlgoLiteral.