Ruby: Do not distinguish between symbols and strings in hash keys #17880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
ruby/symbol-string-key-indifference
branch
from
b54bbcd
to
6b60865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, we distinguished between symbols and strings in hash keys. So, for example, we would (correctly) not report flow in cases like
However, doing so meant that the flow summaries for methods such as
with_indifferent_accesswould throw away any known information about the keys, leading to false positive flow.While we could attempt to improve the summaries for methods like
with_indifferent_access, this PR instead simply considers symbol/string hash keys equal when they denote the same value. The only potential downside is false positive flow, like in the example above, but this seems very unlikely in practice. Indeed, DCA confirms that this PR only removes results.