Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Remove FPs from cpp/too-few-arguments #17919

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calumgrant
Copy link
Contributor

@calumgrant calumgrant commented Nov 6, 2024

Fixes https://github.com/github/codeql-c-team/issues/2462

False-positives in this query were due to implicit C function definitions. Arguably, we shouldn't report this alert for implicit C function definitions, because these are much more likely to be extraction errors rather than actual problems.

The current tests pretty well covered the existing behaviour, so I just reused this test.

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions bot added the C++ label Nov 6, 2024
@calumgrant calumgrant force-pushed the calumgrant/bmn/too-few-arguments branch from aa02a12 to 68cafc6 Compare November 8, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant