Brodes/guard flow parsing k #17933
Brodes/guard flow parsing k #17933
Conversation
…boolean flow logic is completed.
…hanges made to guards (baseline expected file).
…instruction if one exists.
…eriving instruction if one exists." This reverts commit d17dee5.
…l uses of getDerivedInstruction to occur in 'base cases", specially only the compares_lt compares_eq and unary_compares_eq predicates. The premise is that users can modify/add any other logic without having to know about getDerivedInstruction; however, any updates to the compares_lt/eq predicates are the only place where the derived instruction must be used.
…based integer extraction. Updated int_val to handle conversions.
| private int int_value(Instruction i) { | ||
| result = valueNumber(i).getAnInstruction().(IntegerOrPointerConstantInstruction).getValue().toInt() | ||
| result = | ||
| valueNumber(i).getAnInstruction().(IntegerOrPointerConstantInstruction).getValue().toInt() | ||
| or | ||
| // handle conversions | ||
| result = int_value(valueNumber(i).getAnInstruction().(ConvertInstruction).getUnary()) |
There was a problem hiding this comment.
Watch out with materializing all Instructions when all we really care about is the value number. If we instead change the i parameter to be a ValueNumber instead this predicate will be a lot smaller.
Note that this will require changing all the callers so that they convert the argument to a value number. You can define an (inline) helper predicate to do that conversion for you. This will keep all callers as-is, and still avoid unnecessary materialization
There was a problem hiding this comment.
good point, but what about inlining int_value instead?
There was a problem hiding this comment.
You can't inline it since it's recursive, unfortunately.
There was a problem hiding this comment.
Ah true true. The inline helper function I think is the winner then, which is basically the best of both worlds.
|
Worked with @MathiasVP on a prior solution of his to find inefficiencies and worked out conversion concerns. We are going to take the lessons learned here and put them into that PR. Closing this draft. |
No description provided.