Rust: Add unresolved macro calls diagnostic #17940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct the test, but affects VSCode runs).
hvitved
previously approved these changes
Nov 11, 2024
|
Forgot about this PR. Now updated, conflict fixed. |
hvitved
previously approved these changes
Nov 25, 2024
|
Turns out this needed merging with main again, to fix both another merge conflict and a semantic conflict with the recent |
hvitved
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an unresolved macro calls diagnostic, specifically:
rust/summary/summary-statisticsextended with total / resolved / unresolved numbers for macro calls.rust/diagnostics/unresolved-macro-callsnew query listing the unresolved macro calls.I'd like to have put the name of the macro in this message, but as far as I can tell we don't currently extract that (for an unresolved macro).
I'd also like to have a "percent resolved" number in the summary stats table, but I've left it out for now since it would mean changing the type of the second column (and that could interfere with DCAs ability to read it???). I'm not sure how useful a percentage is anyway. But if it's wanted, I'll figure out some way to add it.
If there will be a lot of (sustained) interest in this diagnostic I could add it to metrics tracking as well?