Java/C#: Move test utilities to the query pack. #17968
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
changed the title
michaelnebel
added
the
no-change-note-required
|
DCA looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the test utilities are moved from the test QL packs into the
codeql/<language>-queriesQL packs.We are in the process of moving the experimental queries from the Code QL repo to the CodeQL-Community-Packs repo, and the tests for the experimental queries are relying on the test utilities, which currently aren't being published.
As a temporary workaround a copy of the test utilities are added to the CodeQL-Community-Pack, but we should publish the test utilities to enable sharing.
If we agree to move the test utilities, we should probably do so for all languages for consistency reasons.