Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use git-lfs fork for git_lfs_probe.py #17969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

redsun82
Copy link
Contributor

This switches the fragile git_lfs_probe.py functionality out for a fork of git-lfs providing that functionality.

For the moment, the fork is located at https://github.com/dsp-testing/codeql-git-lfs, and it contains a new git-lfs ls-urls command reusing git-lfs authentication and url fetching, as well as a modified release.yml workflow and upload script for creating special releases there.

Long term, we might want to polish that into something upstreamable. If that takes too long, or if we can't rely on developers having an updated git-lfs, then we might think about moving the dsp-testing fork over to a github/codeql-git-lfs fork (I don't have permissions to do that.

@criemen
Copy link
Collaborator

criemen commented Nov 12, 2024

or if we can't rely on developers having an updated git-lfs

I think we can (always?) think about bundling a lfs binary somewhere (in lfs itself in the internal repo? a public release somewhere?) to work around that requirement, and I do generally like the idea of upstreaming these changes.

@redsun82 redsun82 marked this pull request as ready for review November 13, 2024 15:19
@redsun82 redsun82 requested a review from a team as a code owner November 13, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants