Rust: Add local data flow edge for SSA nodes #18026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| 1000 + i | ||
| } | ||
|
|
||
| fn sink(s: i64) { |
Check notice
Code scanning / CodeQL
Unused variable Note test
hvitved
requested changes
Nov 19, 2024
| ( | ||
| LocalFlow::localFlowStepCommon(nodeFrom, nodeTo) | ||
| or | ||
| SsaFlow::localFlowStep(_, nodeFrom, nodeTo, _) |
There was a problem hiding this comment.
This should be part of localFlowStepCommon.
There was a problem hiding this comment.
I've moved it. I copied the pattern from Ruby where it's also structured st. the SSA flow is not in localFlowStepCommon.
Comment on lines
286
to
288
| // An edge from a pattern to its corresponding SSA definition. | ||
| nodeFrom.(Node::PatNode).getPat() = | ||
| nodeTo.(Node::SsaNode).getDefinitionExt().getSourceVariable().getPat() |
There was a problem hiding this comment.
Should rather be:
// An edge from a pattern/expression to its corresponding SSA definition.
nodeFrom.(Node::AstCfgFlowNode).getCfgNode() =
nodeTo.(Node::SsaNode).getDefinitionExt().(Ssa::WriteDefinition).getControlFlowNode()There was a problem hiding this comment.
Thanks 🙇. That makes sense.
| @@ -112,7 +112,7 @@ | |||
| } | |||
|
|
|||
| /** A data flow node that corresponds to a CFG node for an AST node. */ | |||
| abstract private class AstCfgFlowNode extends Node { | |||
| abstract class AstCfgFlowNode extends Node { | |||
Check warning
Code scanning / CodeQL
UnusedField Warning
hvitved
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some additional local data flow tests and fixes a few missing results by adding an edge from patterns to their corresponding SSA node.
I'm not 100% that this is the correct thing to do in all cases (complex patterns) but it did fix the tests, and we can iterate on this.