Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: Fix jump steps generated by IIFEs and exception flow #18043

Open
wants to merge 19 commits into
base: js/shared-dataflow-branch
Choose a base branch
from
Open

JS: Fix jump steps generated by IIFEs and exception flow #18043

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5ed362f
JS: Add exception test case
asgerf Nov 4, 2024
7acc568
JS: Port exception steps to a universal summary
asgerf Aug 22, 2024
7f2eae0
JS: Add test case for false flow through IIFEs
asgerf Nov 18, 2024
37676f4
JS: Remove jump steps from IIFE steps
asgerf Nov 1, 2024
023dcce
JS: Disable variable capture heuristic
asgerf Nov 1, 2024
d2daec4
JS: Add tests explaining why the IIFE in f2 didn't work
asgerf Nov 19, 2024
80a5a59
JS: Use getUnderlyingValue() a few places in VariableCapture
asgerf Nov 19, 2024
0166990
JS: Block InsecureRandomness flow into test files
asgerf Nov 1, 2024
d1c9e47
JS: More aggressive test file classification
asgerf Nov 1, 2024
b7dd455
JS: Add test case
asgerf Nov 21, 2024
dcdb2e5
JS: Fix callback check so it works without parameters
asgerf Nov 21, 2024
948d21c
JS: Propagate exceptions from summarized callables by default
asgerf Nov 21, 2024
84820ad
Add test for exception flow out of finally()
asgerf Nov 21, 2024
4e62a51
JS: Only apply exception propagator when no other summary applies
asgerf Nov 21, 2024
ce00bd2
JS: More docs
asgerf Nov 21, 2024
9dad2d6
JS: Update DataFlowConsistency
asgerf Nov 21, 2024
1ac7591
JS: Update missed flow in capture-flow.js
asgerf Nov 21, 2024
7a77432
JS: Update lost result in insecure-download
asgerf Nov 21, 2024
930a7b6
JS: Update output changes to nodes/edges/subpaths
asgerf Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion javascript/ql/lib/semmle/javascript/security/dataflow/InsecureRandomnessQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import javascript
private import semmle.javascript.security.SensitiveActions
import InsecureRandomnessCustomizations::InsecureRandomness
private import InsecureRandomnessCustomizations::InsecureRandomness as InsecureRandomness
private import semmle.javascript.filters.ClassifyFiles as ClassifyFiles

/**
* A taint tracking configuration for random values that are not cryptographically secure.
Expand All @@ -20,7 +21,11 @@ module InsecureRandomnessConfig implements DataFlow::ConfigSig {

predicate isSink(DataFlow::Node sink) { sink instanceof Sink }

predicate isBarrier(DataFlow::Node node) { node instanceof Sanitizer }
predicate isBarrier(DataFlow::Node node) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be tested?
A test should probably also test d1c9e47.

node instanceof Sanitizer
or
ClassifyFiles::isTestFile(node.getFile())
}

predicate isBarrierOut(DataFlow::Node node) {
// stop propagation at the sinks to avoid double reporting
Expand Down