C#: Default subtypes to true.

[michaelnebel]

No description provided.

[github-actions]

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

• Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",47,10818,54,5
+    System,"``System.*``, ``System``",47,10817,54,5
-    Totals,,104,12893,396,5
+    Totals,,104,12892,396,5

• Changes to framework-coverage-csharp.csv:

- System,54,47,10818,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,5511,5307
+ System,54,47,10817,,6,5,5,,,4,1,,33,2,,6,15,17,4,3,,5511,5306

[michaelnebel]

@owen-mc : Didn't report any changes.

[owen-mc]

Interesting. Do you think it's a feature that isn't used much? Or is it possible that inheritance isn't quite working as intended?

[michaelnebel]

Interesting. Do you think it's a feature that isn't used much? Or is it possible that inheritance isn't quite working as intended?

I think it works as intended, but maybe many of the summaries that already were relevant for subtypes = true had that set. The FlowSummaries test also reports that changing the logic only means that all the summaries applies to 44 extra callables (in all the libraries/frameworks included in the test) - so it is not that surprising that we don't see any changes in the alerts.

[michaelnebel]

QA run: https://github.com/github/codeql-qa-ops/issues/233

[michaelnebel]

@owen-mc : The QA dashboard only shows a few alert changes, so I don't think it will have a big effect for C# if we set the subtypes = true as default.

[owen-mc]

Great. Out of interest, did you check those alerts to see if you think they are valid?