Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: add extended canonical paths on enum variants #18083

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

redsun82
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Nov 22, 2024
@@ -4,13 +4,14 @@
*/

import codeql.rust.elements.Abi
import codeql.rust.elements.Addressable

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Item
.
Redundant import, the module is already imported inside
codeql.rust.elements.Variant
.
Comment on lines +9 to +13
/**
* Something that can be addressed by a path.
*
* TODO: This does not yet include all possible cases.
*/

Check warning

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.
Comment on lines +15 to +19
/**
* Something that can be addressed by a path.
*
* TODO: This does not yet include all possible cases.
*/

Check warning

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.
@hvitved
Copy link
Contributor

hvitved commented Nov 22, 2024

Please remember to run DCA before merging. I have started a DCA run. Forgot to disable DB caching, so have started a new DCA run.

hvitved
hvitved previously approved these changes Nov 25, 2024
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (needs to be rebased, though).

hvitved
hvitved previously approved these changes Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants