Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: add SHA3 family to list of secure crypto algorithms #18084

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Nov 22, 2024

Pull Request checklist

All query authors

Fixes: #18082

@aibaars aibaars marked this pull request as ready for review November 22, 2024 18:03
@aibaars aibaars requested a review from a team as a code owner November 22, 2024 18:03
@aibaars aibaars mentioned this pull request Nov 22, 2024
jcogs33
jcogs33 previously approved these changes Nov 24, 2024
Copy link
Contributor

@jcogs33 jcogs33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I think SHA3-224 may be deprecated soon based on NIST's most recent draft revision of Transitioning the Use of Cryptographic Algorithms and Key Lengths. I suppose since the draft is not officially published yet, we can still list SHA3-224 as secure for now?

Drop the 224bits variant as it looks like SHA3-224 may be deprecated soon based on NIST's most recent draft revision of Transitioning the Use of Cryptographic Algorithms and Key Lengths
@aibaars
Copy link
Contributor Author

aibaars commented Nov 25, 2024

Looks good to me, although I think SHA3-224 may be deprecated soon based on NIST's most recent draft revision of Transitioning the Use of Cryptographic Algorithms and Key Lengths. I suppose since the draft is not officially published yet, we can still list SHA3-224 as secure for now?

Thanks for checking that. I think we can just drop the 224 variant. I doubt many people are using it anyway.

@aibaars aibaars merged commit c2b342f into main Nov 25, 2024
15 checks passed
@aibaars aibaars deleted the aibaars/java-sha3 branch November 25, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] False positive
3 participants