Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Napalys/regexp unknown flags #18089

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Napalys/regexp unknown flags #18089

wants to merge 4 commits into from
+19 −6

Conversation

Napalys
Copy link
Contributor

@Napalys Napalys commented Nov 25, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions bot added the JS label Nov 25, 2024
@Napalys
JS: In oprder to keep code more consistent removed predicate isGlobal…
b39a8fe 
… from RegExpCreationNode and reused RegExp::isGlobal in std
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-krogh erik-krogh erik-krogh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Napalys @erik-krogh