Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Generate ParamBase, a superclass of Param and SelfParam #18092

Merged
merged 2 commits into from
Nov 25, 2024

Rust: Use `ParamBase` in data flow implementation

0de6658
Select commit
Loading
Failed to load commit list.
Merged

Rust: Generate ParamBase, a superclass of Param and SelfParam #18092

Rust: Use `ParamBase` in data flow implementation
0de6658
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Nov 25, 2024 in 5s

4 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 4 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 6 warnings
  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 5 in rust/ql/test/extractor-tests/generated/Param/gen_param.rs

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable Note generated test

Variable 'x' is not used.

Check notice on line 5 in rust/ql/test/extractor-tests/generated/SelfParam/gen_self_param.rs

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable Note generated test

Variable 'value' is not used.

Check warning on line 276 in rust/ql/lib/codeql/rust/dataflow/internal/DataFlowImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant cast Warning

Redundant cast to
ParameterNode
Loading
.

Check warning on line 14 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Abi
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Addressable
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ArgList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmDirSpec
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmOperand
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmOperandExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmOption
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmPiece
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmRegSpec
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AssocItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AssocItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Attr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Callable
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ClosureBinder
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Comment
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Expr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FieldList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.GenericArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.GenericArgList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.GenericParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.GenericParamList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Label
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetElse
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroCall
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroItems
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroStmts
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchArm
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchArmList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchGuard
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Meta
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Name
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParamBase
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParamList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParenthesizedArgList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Pat
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Path
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathSegment
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RecordExprField
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RecordExprFieldList
Loading
.
Redundant import, the module is alr

Check warning on line 15 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.ArrayExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AssocItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AwaitExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BecomeExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BinaryExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BlockExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BreakExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CallExprBase
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Callable
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CastExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Const
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ConstParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ContinueExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Enum
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternBlock
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternCrate
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FieldExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ForExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.IdentPat
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.IfExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Impl
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.IndexExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetStmt
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LifetimeParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LiteralExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LoopExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroCall
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroDef
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroRules
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchArm
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchArmList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Module
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.OffsetOfExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParamBase
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParenExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PrefixExpr
Loading
.
Redundant import, the module is already imported inside [c

Check warning on line 101 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Param
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.SelfParam
Loading
.

Check warning on line 157 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.ArrayType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AssocTypeArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CastExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Const
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ConstParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.DynTraitType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FnPtrType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ForType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Impl
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ImplTraitType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.InferType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetStmt
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.NeverType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.OffsetOfExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParamBase
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParenType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathSegment
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PtrType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RecordField
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RefType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RetType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.SliceType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Static
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TupleField
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TupleType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeBound
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.WherePred
Loading
.

Check warning on line 7 in rust/ql/lib/codeql/rust/elements/ParamBase.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Attr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeRepr
Loading
.