Ruby 3.1 features #7753
Merged
Ruby 3.1 features #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
force-pushed
the
ruby-3.1
branch
7 times, most recently
from
3b5b4f5 to
a29d905
Compare
aibaars
force-pushed
the
ruby-3.1
branch
5 times, most recently
from
5809718 to
e3e88bd
Compare
nickrolfe
reviewed
Feb 2, 2022
ruby/downgrades/24d81950f3ab7e67e14553e1a5111a04e8ae8445/upgrade.properties
Show resolved
Hide resolved
hvitved
requested changes
Feb 3, 2022
|
|
||
| /** Gets the variable access corresponding to this variable reference pattern. */ | ||
| LocalVariableReadAccess getVariableAccess() { toGenerated(result) = g.getName() } | ||
| /** Gets the value this reference pattern matches against. */ |
There was a problem hiding this comment.
Should we rename to getExpr?
Also, I think we should add an example, something like For example `2 * x` in `^(2 * x)`
|
|
||
| final override string toString() { result = "^..." } | ||
|
|
||
| final override AstNode getAChild(string pred) { | ||
| override AstNode getAChild(string pred) { |
There was a problem hiding this comment.
I think this can remain final.
| } | ||
| } | ||
|
|
||
| private module AnonymousBlockParameterSynth { |
There was a problem hiding this comment.
Add ql doc, something like
/**
* ```rb
* def foo(&)
* bar(&)
* end
* ```
* desugars to,
* ```rb
* def foo(&__synth_0)
* bar(&__synth_0)
* end
* ```
*/
nickrolfe
approved these changes
Feb 4, 2022
|
@hvitved Are you happy with this PR and the DCA results? |
|
I had a quick look at the DCA results and it looks like there are no alert changes and the analysis times didn't change significantly. |
hvitved
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the tree-sitter grammar with the following Ruby 3.1 features
See also: tree-sitter/tree-sitter-ruby#201