-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support GitHub enterprise api #197
Merged
jmeridth
merged 8 commits into
github:main
from
ricardojdsilva87:feat/support-github-enterprise-api
Oct 30, 2024
Merged
feat: support GitHub enterprise api #197
jmeridth
merged 8 commits into
github:main
from
ricardojdsilva87:feat/support-github-enterprise-api
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardojdsilva87
requested review from
jmeridth,
sutterj and
zkoppert
as code owners
October 28, 2024 12:52
ricardojdsilva87
changed the title
Feat/support GitHub enterprise api
feat/support GitHub enterprise api
Oct 28, 2024
ricardojdsilva87
changed the title
feat/support GitHub enterprise api
feat: support GitHub enterprise api
Oct 28, 2024
jmeridth
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things. This looks great. Thank you for the PR.
5 tasks
jmeridth
previously approved these changes
Oct 29, 2024
auto-merge was automatically disabled
October 29, 2024 09:34
Head branch was pushed to by a user without write access
jmeridth
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
This Pull request is based on the already merged github/evergreen#256 to give support to GitHub Enterprise login using a GitHub App also created on GitHub Enterprise
Apart of the necessary changes on the
auth.py
file to support this feature, some minor changes were added to this PR, the.coveragerc
file was also added to ignore test files for code coverage, with this change the code coverage went below 80% so a few more tests were added.Code coverage
Tested against a repository on GHE enterprise the code created a
contributors.json
andcontributors.md
fileReadiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducing@jeffrey-luszcz
Reviewer
bug
,documentation
,enhancement
,infrastructure
,maintenance
orbreaking