Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use weekly cadence for workflow examples #52

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

lelia
Copy link
Contributor

@lelia lelia commented Feb 16, 2024

Pull Request

Updates the basic and advanced workflow examples to use a weekly schedule cadence, rather than monthly.

Fixes #51.

Proposed Changes

With this change, the example cron workflow will run weekly on Saturdays.

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@lelia lelia requested a review from zkoppert as a code owner February 16, 2024 23:25
Copy link
Contributor

@MorganPattersonSignet MorganPattersonSignet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that my approval means anything here, but I'm glad you added this because I would've ended up coming back for another PR when I realized the schedule was off

@zkoppert zkoppert added the documentation Improvements or additions to documentation label Feb 20, 2024
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weekly does make more sense. Thanks for contributing @lelia!

@zkoppert zkoppert merged commit 4fd2186 into github:main Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monthly schedule used for weekly workflow examples
3 participants