Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve topic "Web accessibility" #4581

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

shaedrich
Copy link
Contributor

@shaedrich shaedrich commented Jan 12, 2025

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Could be more precise

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@shaedrich shaedrich requested a review from a team as a code owner January 12, 2025 03:18
@shaedrich shaedrich mentioned this pull request Jan 12, 2025
13 tasks
@shaedrich
Copy link
Contributor Author

1) Failure:
topics::web-accessibility topic#test_0002_does not have an alias for a topic that has its own curated content [test/topics_test.rb:22]:
alias(es) accessibility already have a topic defined, please move to 'related' instead.
Expected ["accessibility"] to be empty.

Okay, this is weird 🤨 When you look at https://github.com/topics/web-accessibility, it's displayed as uncurated (this was why I created this PR), but apparently, despite this, the topic web-accessibility exists in this topic as it has been created 2 years ago. Is this a bug or am I missing something? When this is fixed, I suggest merging the two.

Same with vue by the way (also curated here), web-components (curated here), yaml (curated here), and webextension (curated here, see also: #4577)

@shaedrich shaedrich changed the title Create topic "Accessibility" Improve topic "Web accessibility" Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant