Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only release automatically on Major, minor, or vuln fix PRs #105

Closed
zkoppert opened this issue Apr 23, 2024 · 5 comments
Closed

Only release automatically on Major, minor, or vuln fix PRs #105

zkoppert opened this issue Apr 23, 2024 · 5 comments
Assignees
@jmeridth
Labels
enhancement New feature or request

Comments

@zkoppert
Copy link
Member

Is your feature request related to a problem?

Yes, Currently our automated release process on actions releases after every merge to main. This could create more noise than necessary. For example if its only a documentation related update or dependabot PR than we don't really need to create a release for that.

Related OSPO Tool

automatic-contrib-prs GitHub Action, cleanowners GitHub Action, contributors GitHub Action, evergreen GitHub Action, internal-contribution-forks GitHub App, issues-metrics GitHub Action, stale-repos GitHub Action

Describe the solution you'd like

We should only create a release for major, minor, and vulnerability fixes.

Describe alternatives you've considered

No response

Additional context

No response
@zkoppert zkoppert added the enhancement New feature or request label Apr 23, 2024
@jmeridth
Copy link
Member

jmeridth commented Apr 23, 2024 •
edited
Loading

Initial thought is label detection but not clear on how to detect labels on the last merge to main from GitHub Actions. Still researching this. We can either always do the release and then mark no-release label on ones we don't want a release or vice-versa, add release label for when we want the automated release to fire. Can even auto label with release when it is CVE/Security or major/minor related. 🤔

When will releases occur:

  • is major, minor version bump
  • is CVE/security related PR (need to label for this)
  • explicit release label added to PR

wdyt @zkoppert

@zkoppert
Copy link
Member Author

Looks great!!

@jmeridth jmeridth self-assigned this Apr 25, 2024
@jmeridth
Copy link
Member

jmeridth commented Apr 25, 2024 •
edited
Loading

I'm not finding a way to detect the last pull request's labels when a merge to the default branch occurs. May have to rethink our release workflow 🤔

Update: changing from push to main to closed pull request on main, we retain access to a pull request's labels without having to make API calls. PRs inbound.

jmeridth added a commit to github/cleanowners that referenced this issue Apr 28, 2024
@jmeridth
feat: release on specific labels
aabd0b3 
Related to github/github-ospo#105

Only generate a release and new action container images
if our semver related labels (`breaking`, `enhancement`) or
the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation
happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having
to make API cals.

Currently we'd still need to label a pull request with `release` if
it is a dependabot or manual pull request related to a CVE or security
fix.

- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
jmeridth added a commit to github/cleanowners that referenced this issue Apr 28, 2024
@jmeridth
feat: release on specific labels
9ebc03f 
Related to github/github-ospo#105

Only generate a release and new action container images
if our semver related labels (`breaking`, `enhancement`) or
the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation
happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having
to make API cals.

Currently we'd still need to label a pull request with `release` if
it is a dependabot or manual pull request related to a CVE or security
fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
jmeridth added a commit to github/cleanowners that referenced this issue Apr 28, 2024
@jmeridth
feat: release on specific labels
e22ebd8 
Related to github/github-ospo#105

Only generate a release and new action container images
if our semver related labels (`breaking`, `enhancement`) or
the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation
happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having
to make API cals.

Currently we'd still need to label a pull request with `release` if
it is a dependabot or manual pull request related to a CVE or security
fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
This was referenced Apr 28, 2024
Merged
Merged
jmeridth added a commit to github/stale-repos that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
3dfc5e4 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth mentioned this issue Apr 30, 2024
Merged
6 tasks
jmeridth added a commit to github/contributors that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
3b43a9c 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth mentioned this issue Apr 30, 2024
Merged
6 tasks
jmeridth added a commit to github/contributors that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
f7b7e1a 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
jmeridth added a commit to github/stale-repos that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
d99aea5 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
jmeridth added a commit to github/evergreen that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
45ea74f 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth mentioned this issue Apr 30, 2024
Merged
6 tasks
jmeridth added a commit to github/issue-metrics that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
3b5cfd4 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth mentioned this issue Apr 30, 2024
Merged
6 tasks
jmeridth added a commit to github/automatic-contrib-prs that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
e2e2843 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth mentioned this issue Apr 30, 2024
Merged
6 tasks
jmeridth added a commit to github/issue-metrics that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
68a633a 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository
- [x] add dependabot updates

Signed-off-by: jmeridth <[email protected]>
jmeridth added a commit to github/stale-repos that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
a244c61 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository
- [x] update dependencies

Signed-off-by: jmeridth <[email protected]>
jmeridth added a commit to github/automatic-contrib-prs that referenced this issue Apr 30, 2024
@jmeridth
feat: release on specific labels
89564ac 
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository
- [x] update dependencies

Signed-off-by: jmeridth <[email protected]>
@jmeridth
Copy link
Member

This is complete

@zkoppert
Copy link
Member Author

Wohoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmeridth jmeridth

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmeridth @zkoppert