Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to *.lock #2573

Closed
wants to merge 1 commit into from
Closed

Add to *.lock #2573

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 4, 2018

Reasons for making this change:

TODO
Maybe it is not always the best idea to put the yarn.lock file in your repository.
Links to documentation supporting these rule changes:

TODO

If this is a new template:

  • Link to application or project’s homepage: TODO

@luftywiranda13
Copy link

luftywiranda13 commented Jan 4, 2018

But, ignoring lock files by listing them in .gitignore is harmful

https://github.com/luftywiranda13/remove-lockfiles#why
facebook/create-react-app#2014 (comment)

@shiftkey
Copy link
Member

shiftkey commented Jan 4, 2018

@ImDavaloper please provide more context for this change. As @luftywiranda13 mentioned, some lock files that should be committed will be caught by this rule...

@shiftkey
Copy link
Member

From the docs:

All yarn.lock files should be checked into source control (e.g. git or mercurial). This allows Yarn to install the same exact dependency tree across all machines, whether it be your coworker’s laptop or a CI server.

@shiftkey shiftkey closed this Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants