Skip to content

Commit

Permalink
Fix linting errors.
Browse files Browse the repository at this point in the history
  • Loading branch information
MaineC committed Mar 28, 2024
1 parent 2c1ebc1 commit 1a01093
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 14 deletions.
3 changes: 2 additions & 1 deletion config.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def __init__(
enable_mentor_count: str,
min_mentor_comments: str,
max_comments_eval: str,
heavily_involved_cutoff: str ,
heavily_involved_cutoff: str,
search_query: str,
):
self.gh_app_id = gh_app_id
Expand Down Expand Up @@ -102,6 +102,7 @@ def __repr__(self):
f"{self.search_query})"
)


def get_bool_env_var(env_var_name: str) -> bool:
"""Get a boolean environment variable.
Expand Down
7 changes: 1 addition & 6 deletions issue_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
from json_writer import write_to_json
from labels import get_label_metrics, get_stats_time_in_labels
from markdown_writer import write_to_markdown
from most_active_mentors import count_comments_per_user, get_mentor_count
from time_to_answer import get_stats_time_to_answer, measure_time_to_answer
from time_to_close import get_stats_time_to_close, measure_time_to_close
from time_to_first_response import (
Expand All @@ -40,12 +41,6 @@
from time_to_merge import measure_time_to_merge
from time_to_ready_for_review import get_time_to_ready_for_review

from most_active_mentors import (
count_comments_per_user,
get_mentor_count
)
from config import get_env_vars


def search_issues(
search_query: str, github_connection: github3.GitHub
Expand Down
4 changes: 1 addition & 3 deletions most_active_mentors.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,11 @@
Count the number of mentors active at least n times
"""
from collections import Counter
from datetime import datetime
from typing import List, Union

from collections import Counter

import github3

from classes import IssueWithMetrics


Expand Down
5 changes: 1 addition & 4 deletions test_most_active_mentors.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@
from unittest.mock import MagicMock

from classes import IssueWithMetrics
from most_active_mentors import (
count_comments_per_user,
get_mentor_count,
)
from most_active_mentors import count_comments_per_user, get_mentor_count


class TestCountCommentsPerUser(unittest.TestCase):
Expand Down

0 comments on commit 1a01093

Please sign in to comment.