Skip to content

Commit

Permalink
fix: linting errors after super-linter upgrade
Browse files Browse the repository at this point in the history
- [x] group commands instead of instead of individual redirects
- [x] double quote variable to prevent globbing and word splitting
- [x] disable too-many-positional-arguments pylint linting

Signed-off-by: jmeridth <[email protected]>
  • Loading branch information
jmeridth committed Nov 19, 2024
1 parent 7b454f7 commit 27fea39
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions .github/linters/.python-lint
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ disable=bad-inline-option,
too-many-function-args,
too-many-branches,
too-many-locals,
too-many-positional-arguments,
too-many-statements,
useless-suppression,
use-symbolic-message-instead,
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/major-version-updater.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ jobs:
tag=${GITHUB_REF/refs\/tags\//}
version=${tag#v}
major=${version%%.*}
echo "tag=${tag}" >> "$GITHUB_OUTPUT"
echo "version=${version}" >> "$GITHUB_OUTPUT"
echo "major=${major}" >> "$GITHUB_OUTPUT"
{ echo "tag=${tag}"; echo "version=${version}"; echo "major=${major}"; } >> "$GITHUB_OUTPUT"
- name: force update major tag
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
id: get_tag_name
run: |
short_tag=$(echo ${{ steps.release-drafter.outputs.tag_name }} | cut -d. -f1)
echo "SHORT_TAG=$short_tag" >> $GITHUB_OUTPUT
echo "SHORT_TAG=$short_tag" >> "$GITHUB_OUTPUT"
create_action_images:
needs: create_release
runs-on: ubuntu-latest
Expand Down

0 comments on commit 27fea39

Please sign in to comment.