Skip to content

Commit

Permalink
fix: Catch review comments with no valid user
Browse files Browse the repository at this point in the history
Signed-off-by: Zack Koppert <[email protected]>
  • Loading branch information
zkoppert committed Jun 25, 2024
1 parent 2af47be commit 511a59e
Showing 1 changed file with 16 additions and 11 deletions.
27 changes: 16 additions & 11 deletions time_to_first_response.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,22 @@ def measure_time_to_first_response(
# so we may also get the first review comment time
if pull_request:
review_comments = pull_request.reviews(number=50) # type: ignore
for review_comment in review_comments:
if ignore_comment(
issue.issue.user,
review_comment.user,
ignore_users,
review_comment.submitted_at,
ready_for_review_at,
):
continue
first_review_comment_time = review_comment.submitted_at
break
try:
for review_comment in review_comments:
if ignore_comment(
issue.issue.user,
review_comment.user,
ignore_users,
review_comment.submitted_at,
ready_for_review_at,
):
continue
first_review_comment_time = review_comment.submitted_at
break
except TypeError as e:
print(
f"An error occurred processing review comments. Perhaps the review contains a ghost user. {e}"
)

# Figure out the earliest response timestamp
if first_comment_time and first_review_comment_time:
Expand Down

0 comments on commit 511a59e

Please sign in to comment.