Skip to content

Commit

Permalink
fix: allow access to forked pull request labels
Browse files Browse the repository at this point in the history
Release fails if pull request is from a fork currently because
we can't access the labels on the forked pull request which
helps us determine semver for next release.

Saw this after merging #283 (from a fork)

Add pull_request_target to release action workflow

I am not worried about the security implications with us checking
out the forked pull requests code.  This action only fires after
a merge to main so this means the pull request code has been reviewed
by a maintainer.  We are post-CI/code run.

Signed-off-by: jmeridth <[email protected]>
  • Loading branch information
jmeridth committed May 19, 2024
1 parent 7b1aa4c commit 6fd89f9
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
- closed
branches:
- main
pull_request_target:
types:
- closed
branches:
- main

permissions:
contents: read
Expand Down

0 comments on commit 6fd89f9

Please sign in to comment.