Merge pull request #97 from id/fix-time-to-first-response

fix: fix time to first response
github · Aug 7, 2023 · f5bda66 · f5bda66
2 parents c3d29d0 + 3d63f98
commit f5bda66
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/test_time_to_first_response.py b/test_time_to_first_response.py
@@ -33,12 +33,14 @@ def test_measure_time_to_first_response(self):
         """
         # Set up the mock GitHub issues
         mock_issue1 = MagicMock()
-        mock_issue1.comments = 1
+        mock_issue1.comments = 2
         mock_issue1.created_at = "2023-01-01T00:00:00Z"
 
         mock_comment1 = MagicMock()
         mock_comment1.created_at = datetime.fromisoformat("2023-01-02T00:00:00Z")
-        mock_issue1.issue.comments.return_value = [mock_comment1]
+        mock_comment2 = MagicMock()
+        mock_comment2.created_at = datetime.fromisoformat("2023-01-02T12:00:00Z")
+        mock_issue1.issue.comments.return_value = [mock_comment1, mock_comment2]
 
         # Call the function
         result = measure_time_to_first_response(mock_issue1, None)
@@ -105,7 +107,9 @@ def test_measure_time_to_first_response_only_ignored_users(self):
         mock_issue1.issue.comments.return_value = [mock_comment1, mock_comment2]
 
         # Call the function
-        result = measure_time_to_first_response(mock_issue1, None, ["ignored_user", "ignored_user2"])
+        result = measure_time_to_first_response(
+            mock_issue1, None, ["ignored_user", "ignored_user2"]
+        )
         expected_result = None
 
         # Check the results

diff --git a/time_to_first_response.py b/time_to_first_response.py
@@ -56,6 +56,7 @@ def measure_time_to_first_response(
             if comment.user.login in ignore_users:
                 continue
             first_comment_time = comment.created_at
+            break
 
         # Check if the issue is actually a pull request
         # so we may also get the first review comment time
@@ -66,6 +67,7 @@ def measure_time_to_first_response(
                 if review_comment.user.login in ignore_users:
                     continue
                 first_review_comment_time = review_comment.submitted_at
+                break
 
         # Figure out the earliest response timestamp
         if first_comment_time and first_review_comment_time: