Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all env variables are being checked via the get_env_vars() function #168

Closed
zkoppert opened this issue Nov 6, 2023 · 3 comments · Fixed by #171
Closed

Not all env variables are being checked via the get_env_vars() function #168

zkoppert opened this issue Nov 6, 2023 · 3 comments · Fixed by #171
Labels

Comments

@zkoppert
Copy link
Member

zkoppert commented Nov 6, 2023

The design pattern we want to use is to get all env variables from the return of a get_env_vars() call. This is not being used consistently (see functions like get_non_hidden_columns()). We should take the time to comprehensively update to the use of this pattern across all areas of the code.

Thanks to @spier for discovering this issue.

@ananta
Copy link
Contributor

ananta commented Dec 1, 2023

@zkoppert I would love to work on this :)

@zkoppert
Copy link
Member Author

zkoppert commented Dec 1, 2023

Great @ananta ! That would be very helpful! Feel free to get started and let me know what support you need.

@ananta
Copy link
Contributor

ananta commented Dec 2, 2023

Hey @zkoppert , I've refactored the code to use get_env_vars() across the app. There's still some room for improvement, but I'd like to get your thoughts on these changes first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants