Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some configuration options don't work correctly #408

Closed
rakiyoshi opened this issue Oct 21, 2024 · 2 comments · Fixed by #409
Closed

Some configuration options don't work correctly #408

rakiyoshi opened this issue Oct 21, 2024 · 2 comments · Fixed by #409
Assignees
Labels
bug Something isn't working

Comments

@rakiyoshi
Copy link

rakiyoshi commented Oct 21, 2024

Describe the bug

The configurations hide_label_metrics, hide_items_closed_count, non_mentioning_links, report_title, and output_file don't work correctly in some conditions.

The write_to_markdown function has 15 arguments.

def write_to_markdown(
issues_with_metrics: Union[List[IssueWithMetrics], None],
average_time_to_first_response: Union[dict[str, timedelta], None],
average_time_to_close: Union[dict[str, timedelta], None],
average_time_to_answer: Union[dict[str, timedelta], None],
average_time_in_labels: Union[dict, None],
num_issues_opened: Union[int, None],
num_issues_closed: Union[int, None],
num_mentor_count: Union[int, None],
labels=None,
search_query=None,
hide_label_metrics=False,
hide_items_closed_count=False,
non_mentioning_links=False,
report_title="",
output_file="",

However, it is called with 14 arguments in issue_metrics.py because it lacks the argument hide_label_metrics.

write_to_markdown(
issues_with_metrics,
stats_time_to_first_response,
stats_time_to_close,
stats_time_to_answer,
stats_time_in_labels,
num_issues_open,
num_issues_closed,
num_mentor_count,
labels,
search_query,
hide_items_closed_count,
non_mentioning_links,
report_title,
output_file,

This causes the argument hide_label_metrics and the following arguments not to work correctly.

To Reproduce

To set a query that does not have subquery type:discussions in it and returns at least one issue.

Expected behavior

The configurations hide_label_metrics, hide_items_closed_count, non_mentioning_links, report_title, and output_file=output_file work.

Screenshots

No response

Additional context

No response

@rakiyoshi rakiyoshi added the bug Something isn't working label Oct 21, 2024
@rakiyoshi rakiyoshi changed the title Some configuration don't work correctly Some configuration options don't work correctly Oct 21, 2024
@zkoppert
Copy link
Member

Well that's not good! I'll get a fix up for this. Thanks for the details!!

@zkoppert
Copy link
Member

PR is up at #409 for review and a release is set to deploy once the pull request merge completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants