Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct positional args for write_to_markdown() #409

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Oct 21, 2024

Pull Request

fixes #408

Proposed Changes

This pull request includes changes to the issue_metrics.py file to correct the functionality and and improve readability of the main function. The most important changes include passing through a previously mis-implemented environment variable, and updating the write_to_markdown function call to use the new variable hide_label_metrics and prevent future mistakes by using keyword arguments instead of positional.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@github-actions github-actions bot added the fix label Oct 21, 2024
@zkoppert zkoppert marked this pull request as ready for review October 21, 2024 17:21
@zkoppert zkoppert self-assigned this Oct 21, 2024
@zkoppert zkoppert merged commit 852d290 into main Oct 21, 2024
33 checks passed
@zkoppert zkoppert deleted the fix_markdown_args branch October 21, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some configuration options don't work correctly
2 participants