Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Getting Started section in README #145

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

Okabe-Junya
Copy link
Contributor

@Okabe-Junya Okabe-Junya commented Oct 17, 2023

close #142

Proposed Changes

  • add Getting Started section in README

Readiness Checklist

Is the term Quick Start really appropriate? There are similar expressions like:

  • Getting Started
  • Usage
  • Tutorial
  • Simple Example/Basic Example
  • ...

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@Okabe-Junya
Copy link
Contributor Author

This PR only involves updates to the documentation, so it won't fail any linting or tests.

@zkoppert zkoppert added the documentation Improvements or additions to documentation label Oct 17, 2023
README.md Outdated Show resolved Hide resolved
Co-authored-by: Zack Koppert <[email protected]>
@Okabe-Junya Okabe-Junya changed the title docs: add Quick Start section in README docs: add Getting Started section in README Oct 18, 2023
@Okabe-Junya
Copy link
Contributor Author

Thank you for the review!!

I approved your suggestion commit, and I've also updated the PR title and the "Proposed Changes" section.

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this example! Hopefully this will help speed up the process of getting started for new users!

@zkoppert zkoppert merged commit b3bacd1 into github:main Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Simple example in main README?
2 participants