Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container image name #247

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: container image name #247

merged 1 commit into from
Apr 22, 2024

Conversation

jmeridth
Copy link
Member

Fixes #246

Pull Request

Proposed Changes

  • needs to be owner/repo, not just repo (excellent catch @zkoppert, thank you)
  • fix pull request template file name, all underscores for that

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, or breaking

@jmeridth jmeridth self-assigned this Apr 22, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner April 22, 2024 22:42
@github-actions github-actions bot added the fix label Apr 22, 2024
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

- [x] needs to be owner/repo, not just repo (excellent catch @zkoppert, thank you)
- [x] remove unnecessary mobykit versioning

Signed-off-by: jmeridth <[email protected]>
Co-authored-by: Zack Koppert <[email protected]>
@jmeridth jmeridth merged commit e7731ae into main Apr 22, 2024
27 checks passed
@jmeridth jmeridth deleted the jm-fix-image-releases branch April 22, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error building GitHub Action container image and pushing to ghcr.io during automated release
2 participants