fix: issue accessing repo when not provided in query #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #290 - [x] handle trying to access repository from dictionary when not present (use default of empty string) - [x] add test to ensure we cover this scenario - [x] handle issue where `time_to_close` variable was being access before possibly being declared Signed-off-by: jmeridth <[email protected]>
jmeridth
force-pushed
the
jm-search-query-bugs
branch
from
332f66a
to
901b160
Compare
zkoppert
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290
Pull Request
Proposed Changes
total_time_to_closevariable was being access before possibly being declaredE0606: Possibly using variable 'total_time_to_close' before assignment (possibly-used-before-assignment))Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
fix,documentation,enhancement,infrastructure,maintenance, orbreaking