Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: French typos #3085

Merged
merged 10 commits into from
Sep 27, 2023
Merged

Fix: French typos #3085

merged 10 commits into from
Sep 27, 2023

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Sep 2, 2023

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@omahs omahs requested a review from a team as a code owner September 2, 2023 07:14
@omahs omahs temporarily deployed to Pages Preview September 2, 2023 07:15 — with GitHub Actions Inactive
@Mohamad1112we

This comment was marked as spam.

Sign in to view
@Astormalo

This comment was marked as spam.

Sign in to view
ahpook
ahpook approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup!

@ahpook
Copy link
Contributor

ahpook commented Sep 8, 2023 •
edited
Loading

Getting a test failure:

- _site/fr/building-community/index.html
  *  linking to internal hash #ne-tolèrez-pas-les-mauvais-acteurs that does not exist (line 570)
     <a href="../building-community/#ne-tolèrez-pas-les-mauvais-acteurs">agissez immédiatement</a>

The renderer doesn't like this anchor link on line 195

 [agissez immédiatement](../building-community/#ne-tol&egrave;rez-pas-les-mauvais-acteurs)

Rather than using the &egrave; html entity, can you use the UTF-8 ligature character in the code here, the same as the acute accents? ex: è I think this will fix this error.

è
LATIN SMALL LETTER E WITH GRAVE
Unicode: U+00E8, UTF-8: C3 A8

auto-merge was automatically disabled September 9, 2023 06:10

Head branch was pushed to by a user without write access

@omahs
Copy link
Contributor Author

omahs commented Sep 9, 2023

@ahpook I just changed the anchor link

@underwoo16 underwoo16 added this pull request to the merge queue Sep 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2023
@zkoppert zkoppert added this pull request to the merge queue Sep 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2023
@zkoppert zkoppert added this pull request to the merge queue Sep 27, 2023
Merged via the queue into github:main with commit d787e57 Sep 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underwoo16 underwoo16 underwoo16 approved these changes

@ahpook ahpook ahpook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@omahs @Mohamad1112we @Astormalo @ahpook @underwoo16 @zkoppert