-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add tests for spelling #63
Conversation
Nice tooling - we use Danger to offer this kind of feedback inline on my work blog e.g. artsy/artsy.github.io#255 |
Danger looks awesome. I stumbled on remark-lint a few weeks ago and was impressed. It's really powerful and configurable, but it's a little involved due to everything operating on a syntax tree (as opposed to using regular expressions). I don't have a strong preference for tooling, as long as we have thorough tests for the things we care about. |
Auto closed when |
* origin/gh-pages: (324 commits) Ignore readthedocs.org until fixed Fix prose lint errors Add description to metadata Remove `more` section from template add image remove more as a field remove following as a field turn historical vignettes into pull quotes simplify open source example remove further reading links remove further reading links doh ok links removed remove further reading links remove further reading links ok actually deleting the links remove further reading links convert names to github usernames remove further reading links remove further reading links remove further reading links ...
@wooorm I was looking at reviving this PR, but there are a ton of really simple words being marked as misspelt. Any idea what is up? Here is just a sampling of the 2961 warnings:
|
Really weird. I just checked and it seems to be something wrong with the en-us dictionary: en-gb works fine! |
Found it. The American-English dictionary contains lots of white-space between columns, whereas other dictionaries use one space. I’ll push a fix to nspell (underlying checker) in a minute. |
OK, working now. Make sure when updating you the newer nspell is included though. |
@bkeepers still want to merge this? |
In Node.js, we use misspell but it is not part of a test. Here is the PR. nodejs/nodejs.org#1130 |
Thanks for the suggestion @sotayamashita. This project already depends on Ruby and Node. I'm not sure I want to add a Go dependency. I'll look into it, but no promises. |
I'd still love to add this, but closing this since I'm not actively working on this. |
This was addressed by #431 🎉 |
This adds retext-spell to check for spelling. There are currently 200 warnings, mostly from: