Skip to content

Commit

Permalink
Upgrade to kramdown v2 and add kramdown-parser-gfm to allow GFM input
Browse files Browse the repository at this point in the history
  • Loading branch information
parkr committed Aug 5, 2020
1 parent 597b140 commit aaf0227
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 2 deletions.
3 changes: 2 additions & 1 deletion lib/github-pages/dependencies.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ class Dependencies
"jekyll-sass-converter" => "1.5.2",

# Converters
"kramdown" => "1.17.0",
"kramdown" => "2.3.0",
"kramdown-parser-gfm" => "1.1.0",
"jekyll-commonmark-ghpages" => "0.1.6",

# Misc
Expand Down
6 changes: 6 additions & 0 deletions spec/fixtures/kramdown-parser-gfm.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
---

# Test

~~Nope~~Yes
2 changes: 1 addition & 1 deletion spec/github-pages/dependencies_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

describe(GitHubPages::Dependencies) do
CORE_DEPENDENCIES = %w(
jekyll kramdown liquid rouge jekyll-sass-converter
jekyll kramdown kramdown-parser-gfm liquid rouge jekyll-sass-converter
github-pages-health-check
).freeze
PLUGINS = described_class::VERSIONS.keys - CORE_DEPENDENCIES
Expand Down
6 changes: 6 additions & 0 deletions spec/github-pages/integration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ def rm_destination
end
end

context "kramdown-parser-gfm" do
it "converts GFM to HTML" do
expect(contents).to match("<del>Nope</del>Yes")
end
end

context "liquid" do
it "renders liquid templates" do
expect(contents).to match("Value of foo: bar")
Expand Down

0 comments on commit aaf0227

Please sign in to comment.