Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(STYLEGUIDE.md): use list item instead of codeblock #116

Merged
merged 3 commits into from
Oct 13, 2022
Merged

fix(STYLEGUIDE.md): use list item instead of codeblock #116

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a33679f
fix(STYLEGUIDE.md): use list item instead of codeblock
francisfuzz Oct 5, 2022
4b7844a
Merge branch 'master' into francisfuzz/styleguide-syntax-update
francisfuzz Oct 11, 2022
2ab6fce
Merge branch 'master' into francisfuzz/styleguide-syntax-update
bensheldon Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions STYLEGUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,9 +797,9 @@ names.select do |name|
end.map { |name| name.upcase }
```

Some will argue that multiline chaining would look OK with the use of {...}, but they should
ask themselves - is this code really readable and can't the block's contents be extracted into
nifty methods?
* Some will argue that multiline chaining would look OK with the use of `{...}`,
but they should ask themselves: is this code really readable and can't the block's
contents be extracted into nifty methods?

* Avoid `return` where not required.
<a name="avoid-return"></a><sup>[[link](#avoid-return)]</sup>
Expand Down Expand Up @@ -893,4 +893,4 @@ result = hash.map { |_, v| v + 1 }

Refactoring is even better. It's worth looking hard at any code that explicitly checks types.

[rubocop-guide]: https://github.com/rubocop-hq/ruby-style-guide
[rubocop-guide]: https://github.com/rubocop-hq/ruby-style-guide