Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other formats of link_to in the RailsAccessibility/LinkHasHref rule #3

Open
khiga8 opened this issue Sep 1, 2022 · 0 comments
Assignees

Comments

@khiga8
Copy link
Contributor

khiga8 commented Sep 1, 2022

The RailsAccessibility/LinkHasHref rule has been extended and still doesn't have support for various formats of link_to which are difficult to account for, for example:

<%= link_to XXXX do %>
  Text
<% end %>

for example:

<%= link_to network_dependabot_show_path(update_job_id: update_config.last_full_update_run.id) do %>
  Last checked <%= time_ago_in_words_js Time.at(update_config.last_full_update_run.finished_at.seconds) %>
<% end %>
@bolonio bolonio changed the title LinkHasHref is broken Add support for links with children in the RubocopRailsAccessibility/LinkHasHref rule Sep 2, 2022
@bolonio bolonio reopened this Sep 22, 2022
@bolonio bolonio changed the title Add support for links with children in the RubocopRailsAccessibility/LinkHasHref rule Add support for other formats of link_to in the RubocopRailsAccessibility/LinkHasHref rule Sep 22, 2022
@bolonio bolonio changed the title Add support for other formats of link_to in the RubocopRailsAccessibility/LinkHasHref rule Add support for other formats of link_to in the RailsAccessibility/LinkHasHref rule Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants