-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the RubocopRailsAccessibility/LinkHasHref
rule
#4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad that we have to remove it, happy with the change 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 Sad to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it as well from the rules section in the README, please :)
LinkHasHref
ruleRubocopRailsAccessibility/LinkHasHref
rule
Context
The
RubocopRailsAccessibility/LinkHasHref
rule has been extended and still doesn't have support for various formats oflink_to
which are difficult to account for, for example:for example:
This rule also does not seem high priority to fix now (also given it was brokenly implemented in
dotcom
to begin with).This PR removes this rule for now and revisit this later.
Related issue
link_to
in theRailsAccessibility/LinkHasHref
rule #3