Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the RubocopRailsAccessibility/LinkHasHref rule #4

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Sep 2, 2022

Context

The RubocopRailsAccessibility/LinkHasHref rule has been extended and still doesn't have support for various formats of link_to which are difficult to account for, for example:

<%= link_to XXXX do %>
  Text
<% end %>

for example:

<%= link_to network_dependabot_show_path(update_job_id: update_config.last_full_update_run.id) do %>
  Last checked <%= time_ago_in_words_js Time.at(update_config.last_full_update_run.finished_at.seconds) %>
<% end %>

This rule also does not seem high priority to fix now (also given it was brokenly implemented in dotcom to begin with).

This PR removes this rule for now and revisit this later.

Related issue

@khiga8 khiga8 requested a review from bolonio September 15, 2022 14:39
@khiga8 khiga8 marked this pull request as ready for review September 15, 2022 14:39
@khiga8 khiga8 requested a review from a team as a code owner September 15, 2022 14:39
Copy link
Member

@owenniblock owenniblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that we have to remove it, happy with the change 😅

Copy link

@bolonio bolonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 Sad to remove it

Copy link

@bolonio bolonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it as well from the rules section in the README, please :)

@bolonio bolonio merged commit ff9571c into main Sep 21, 2022
@bolonio bolonio deleted the kh-remove-link-has-href-for-now branch September 21, 2022 14:59
@bolonio bolonio changed the title Remove LinkHasHref rule Remove the RubocopRailsAccessibility/LinkHasHref rule Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants