Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git guides a11y updates #1070

Merged
merged 2 commits into from
May 27, 2024
Merged

Git guides a11y updates #1070

merged 2 commits into from
May 27, 2024

Conversation

stamat
Copy link
Contributor

@stamat stamat commented May 17, 2024 •
edited
Loading

Overview

Hey there, big regards from @github/brand-engineering 👋

I'm currently updating the https://github.com/git-guides and I've stumbled on couple small accessibility violations in the guides:

  1. Missing a table heading copy
  2. Heading hierarchy violation

That is all! ✨

@stamat stamat self-assigned this May 17, 2024
@stamat stamat marked this pull request as ready for review May 17, 2024 11:37
@stamat stamat changed the title Stamat/git-guides-a11y-updates Git guides a11y updates May 17, 2024
@stamat stamat merged commit a50017c into main May 27, 2024
4 of 5 checks passed
@stamat stamat deleted the stamat/git-guides-a11y-updates branch May 27, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thapeloza Thapeloza Thapeloza approved these changes

@qiang88550 qiang88550 qiang88550 approved these changes

@tobiasahlin tobiasahlin tobiasahlin approved these changes

Assignees

@stamat stamat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stamat @tobiasahlin @qiang88550 @Thapeloza