-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide more organized output and sorting #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What do you think about further refactoring? class Proofer do
def run
issues
output
end
def issues
# return an array of issues
end
def output
# output the issues
end
end With this architecture we could test the issues and the output separately. Moreover users could override these methods. |
I like it, but I am super behind on releasing a new gem that addresses several bugfixes. I'll open an issue as a reminder for this. |
Closed
Addresses some annoying stack traces
gjtorikian
added a commit
that referenced
this pull request
Nov 11, 2014
Provide more organized output and sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72.
Would appreciate some 👀 from @penibelst when you have the 🕥.
I could not figure out how to do neat ascii separators, so I went with
*
instead. I also apologize for the massive changes in how tests are written, it was a refactor that needed to happen.