Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more organized output and sorting #116

Merged
merged 14 commits into from
Nov 11, 2014
Merged

Conversation

gjtorikian
Copy link
Owner

Closes #72.

Would appreciate some 👀 from @penibelst when you have the 🕥.

I could not figure out how to do neat ascii separators, so I went with * instead. I also apologize for the massive changes in how tests are written, it was a refactor that needed to happen.

@doktorbro
Copy link

What do you think about further refactoring?

class Proofer do

  def run 
    issues
    output
  end

  def issues 
    # return an array of issues
  end

  def output 
    # output the issues
  end

end

With this architecture we could test the issues and the output separately. Moreover users could override these methods.

@gjtorikian
Copy link
Owner Author

What do you think about further refactoring?

I like it, but I am super behind on releasing a new gem that addresses several bugfixes. I'll open an issue as a reminder for this.

@gjtorikian gjtorikian mentioned this pull request Nov 4, 2014
gjtorikian added a commit that referenced this pull request Nov 11, 2014
Provide more organized output and sorting
@gjtorikian gjtorikian merged commit 7ac08ff into master Nov 11, 2014
@gjtorikian gjtorikian deleted the a-better-output branch November 11, 2014 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the output more readable
2 participants