Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better URL parsing through science #122

Merged
merged 3 commits into from
Oct 29, 2014
Merged

Better URL parsing through science #122

merged 3 commits into from
Oct 29, 2014

Conversation

benbalter
Copy link
Contributor

Use Addressable rather than URI.parse to parse URLs.

This provides better support for URL encoded, non-ut8, and other edge case URLs.

Fixes #110.

@benbalter benbalter self-assigned this Oct 8, 2014
@gjtorikian
Copy link
Owner

Me like.

@benbalter
Copy link
Contributor Author

@gjtorikian passing-ish tests. One, failure, which I think is unrelated:

1) Links test fails on redirects if not following
     Failure/Error: output.should match /External link https:\/\/help.github.com\/changing-author-info\/ failed: 301 No error/
       expected "spec/html/proofer/fixtures/links/linkWithRedirect.html: External link http://timclem.wordpress.com/2012/03/01/mind-the-end-of-your-line/ failed: 301 No error\n" to match /External link https:\/\/help.github.com\/changing-author-info\/ failed: 301 No error/
     # ./spec/html/proofer/links_spec.rb:45:in `block (2 levels) in <top (required)>'

@benbalter benbalter changed the title WIP: Better URL parsing through science Better URL parsing through science Oct 10, 2014
@benbalter benbalter assigned gjtorikian and unassigned benbalter Oct 10, 2014
gjtorikian added a commit that referenced this pull request Oct 29, 2014
Better URL parsing through science
@gjtorikian gjtorikian merged commit e23baa1 into gjtorikian:master Oct 29, 2014
@benbalter benbalter deleted the addressable branch October 29, 2014 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on link with url encoded character
2 participants