Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make external hash checker an option #133

Merged
merged 2 commits into from
Nov 14, 2014
Merged

Conversation

gjtorikian
Copy link
Owner

Some websites, like Travis and https://enterprise.github.com/faq, use JavaScript to generate header links for the TOC. This screws up the newly introduced external hash checker, so let's move that into an option.

You can always explicitly ignore an href with href_ignore, but you shouldn't have to create an ignore if you don't want to.

gjtorikian added a commit that referenced this pull request Nov 14, 2014
@gjtorikian gjtorikian merged commit 3f66916 into master Nov 14, 2014
@gjtorikian gjtorikian deleted the make-hashchecks-an-option branch November 14, 2014 17:11
@parkr
Copy link
Contributor

parkr commented Nov 14, 2014

I guess html proofer was doing its job! It caught a call to a non-html link. Would it be possible to use natural html anchor tags there rather than javascript?

@gjtorikian
Copy link
Owner Author

For enterprise's website, sure. For Travis, I don't work there. 😉 No idea why you wouldn't generate the HTML anchor yourself. There are some things JS is good at and some that are just overkill.

@parkr
Copy link
Contributor

parkr commented Nov 14, 2014

OK :) I guess this is a situation where I feel html proofer is doing its job and the sites should be updated, but that's just my personal opinion. More generally, where do we modify html proofer to suit our websites and where do we say "this is how html should be and when it should be a certain way, if you want to use html proofer, you have to abide by these (W3C-related) rules"? #existentialcrisis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants