Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume JSON-LD metadata from a paged API #133

Merged
merged 14 commits into from
Mar 2, 2023
Merged

Consume JSON-LD metadata from a paged API #133

merged 14 commits into from
Mar 2, 2023

Conversation

nein09
Copy link
Collaborator

@nein09 nein09 commented Jan 9, 2023

  • Add a new api source type, that takes an URL template, and pages through it
  • Add tests for the api source type
  • Add a little documentation for the new sourcetype

You can test it out on CCADI's endpoint but it'd be even cooler if you had a different paged API to try it out on:

- sourcetype: api
  name: ccadi
  url: "http://hedeby.uwaterloo.ca/api/metadata?page=%d"
  properName: ccadi
  domain: http://hedeby.uwaterloo.ca
  apipagelimit: 200

Other things I did while I was in here:

  • Move some core acquire functionality into functions so that I can call them from the api sourcetype code
  • Set application/ld+json as a constant in the summoner module

@nein09 nein09 requested review from fils and valentinedwv January 9, 2023 23:39
@valentinedwv
Copy link
Member

Looks good. New function for getting JsonLD should be useful, and testable

@fils fils merged commit ecbab66 into dev Mar 2, 2023
@nein09 nein09 deleted the mm-dev--api branch March 16, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants