Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle getting multiple json-ld objects per page, headlessly or via http #35

Merged
merged 6 commits into from
Oct 14, 2021
Merged

Handle getting multiple json-ld objects per page, headlessly or via http #35

merged 6 commits into from
Oct 14, 2021

Conversation

nein09
Copy link
Collaborator

@nein09 nein09 commented Oct 14, 2021

This change builds up a list of json-ld scripts that it finds in an HTML page and indexes all of them, rather than just picking one. In addition:

  • Move similar / duplicate code that uploads json-ld into a jsonutils library, so headless and non-headless indexing can operate the same way
  • Move json validity checking into that library so it is accessible to the headless indexer
  • add a few tests!

@nein09 nein09 requested a review from fils October 14, 2021 00:44
fils
fils approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@fils fils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the clean up and testing examples..
anxious to try out the headless

@fils fils merged commit f73709e into dev Oct 14, 2021
@nein09 nein09 deleted the multiple-json-per-page branch December 24, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fils fils fils approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nein09 @fils