Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.25.1 to 2.26.0 #2169

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2024

Bumps rubocop-rails from 2.25.1 to 2.26.0.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.26.0

New features

Bug fixes

  • #1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. (@​earlopain)
  • #1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. (@​earlopain)
  • #1337: Fix an error for Rails/Validation when passing no arguments. (@​earlopain)
  • #1330: Fix an error for Rails/WhereNot when using placeholder without second argument. (@​earlopain)
  • #1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. (@​tldn0718)
  • #1313: Fix false positives for Rails/CompactBlank when using collection.reject!. (@​koic)
  • #1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. (@​earlopain)
  • #1306: Make Rails/PluralizationGrammar aware of byte methods. (@​earlopain)
  • #1302: Allow params receiver by default for Style/CollectionMethods. (@​koic)
  • #1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). (@​earlopain)

Changes

Changelog

Sourced from rubocop-rails's changelog.

2.26.0 (2024-08-24)

New features

Bug fixes

  • #1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. ([@​earlopain][])
  • #1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. ([@​earlopain][])
  • #1337: Fix an error for Rails/Validation when passing no arguments. ([@​earlopain][])
  • #1330: Fix an error for Rails/WhereNot when using placeholder without second argument. ([@​earlopain][])
  • #1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. ([@​tldn0718][])
  • #1313: Fix false positives for Rails/CompactBlank when using collection.reject!. ([@​koic][])
  • #1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. ([@​earlopain][])
  • #1306: Make Rails/PluralizationGrammar aware of byte methods. ([@​earlopain][])
  • #1302: Allow params receiver by default for Style/CollectionMethods. ([@​koic][])
  • #1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). ([@​earlopain][])

Changes

Commits
  • 334861e Cut 2.26.0
  • 91c0f30 Update Changelog
  • 6bc9b1c Merge pull request #1337 from Earlopain/validation-error
  • aa2bf3e Merge pull request #1336 from koic/add_new_rails_enum_syntax_cop
  • d17c7b5 Merge pull request #1309 from ytjmt/support-new-enum-syntax-for-enum-hash-cop
  • 2201bd8 [Fix #1238] Add new Rails/EnumSyntax cop
  • ebd652f Merge pull request #1335 from Earlopain/error-bulk-change-table
  • 5e2237a Fix an error for Rails/Validation when passing no arguments
  • a9db5f5 Update Rails/Validation specs to modern style
  • 75be327 Merge pull request #1334 from Earlopain/cop-registry-deprecated
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Aug 26, 2024
@Throne3d
Copy link
Contributor

@dependabot recreate

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.25.1 to 2.26.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.25.1...v2.26.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rails-2.26.0 branch from b021ff9 to f44fa41 Compare August 31, 2024 13:56
@Throne3d
Copy link
Contributor

Problematic when I run it locally - see rubocop/rubocop-rails#1269

Let's wait for the next release

Copy link
Contributor

@Throne3d Throne3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@Throne3d Throne3d closed this Aug 31, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 31, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/rubocop-rails-2.26.0 branch August 31, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant